Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add basic nova search #1102

Merged
merged 10 commits into from
Feb 14, 2024
Merged

feat: add basic nova search #1102

merged 10 commits into from
Feb 14, 2024

Conversation

brancoder
Copy link
Collaborator

Description of change

resolves #927

Type of change

Choose a type of change, and delete any options that are not relevant.

  • Enhancement (a non-breaking change which adds functionality)

Change checklist

  • My code follows the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@brancoder brancoder linked an issue Feb 9, 2024 that may be closed by this pull request
[Task]: Add basic nova search support #927
Closed
@brancoder brancoder marked this pull request as ready for review February 13, 2024 10:17
begonaalvarezd
begonaalvarezd reviewed Feb 13, 2024
View reviewed changes
Copy link
Member

@begonaalvarezd begonaalvarezd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazig work 🚀
didnt finish the review so for now just added 2 random comments 🙏🏼

api/src/utils/nova/addressHelper.ts Show resolved Hide resolved
api/src/utils/nova/searchQueryBuilder.ts Show resolved Hide resolved
@begonaalvarezd begonaalvarezd changed the title Feat: Add Nova search feat: add basic nova search Feb 14, 2024
@begonaalvarezd begonaalvarezd merged commit dae92f7 into dev Feb 14, 2024
3 of 5 checks passed
@begonaalvarezd begonaalvarezd deleted the feat/add-nova-search branch February 14, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@begonaalvarezd begonaalvarezd begonaalvarezd approved these changes

@msarcev msarcev Awaiting requested review from msarcev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task]: Add basic nova search support
2 participants
@brancoder @begonaalvarezd